Fixed search for repository root directory #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the situation, where one git/svn/hg repository is located inside the directory tree of another, the search incorrectly selects the outer one instead of the inner one.
|
Note that this wasn't merged correctly as the default branch is develop for some reason. We'll review the other PRs that merge into master and then get them into develop together. |
|
Scratch that, now correctly committed in 8de9004. |
|
@groegeorg It seems something about that commit credited your name but not your GitHub username. There are only two ways I know to rectify that: 1. Rebase to add you back and rewrite history, which may mangle commit dates. 2. You can maybe figure out some other contribution to make? 3. We can just let it be, as your name is still in the contribution list. |
|
Actually, there's a much bigger authorship somewhere else, so we'll rebase |
aaronliu0130
pushed a commit
to aaronliu0130/cpplint
that referenced
this pull request
Jan 29, 2024
In the situation, where one git/svn/hg repository is located inside the directory tree of another, the search incorrectly selects the outer one instead of the inner one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation, where one git/svn/hg repository is located inside the
directory tree of another, the search incorrectly selects the outer one
instead of the inner one.