refactor: 💡 change config key from 'svgoOptions' to 'svgo' #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbd56af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BREAKING CHANGE: 🧨 Nuxt config key is now 'svgo', instead of 'svgoOptions'
cpsoinos
force-pushed
the
nuxt-config-options
branch
from
3fd2ca5
to
a20234a
Compare
As discussed in damianstasik/vue-svg-loader#156, 'vue-svg-loader' uses svgo v1. That project looks to be unmaintained, with the latest beta release more than 2 years old. This PR disables the svgo functionality of vue-svg-loader, instead relying on svg/svgo-loader to perform optimizations, essentially making vue-svg-loader wrap the svg content in template tags. ✅ Closes: #37
cpsoinos
force-pushed
the
nuxt-config-options
branch
from
91d679d
to
cbd56af
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.