Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change LoggingDriver to LogDriver #11

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

chenhengqi
Copy link
Contributor

Hello Brian,

I found this project from Docker docs, it's a good starting point for us to implement our own log driver plugin.
But it seems the LoggingDriver should be LogDriver to get it work.

docker: Error response from daemon: logger: no log driver named 'foobar' is registered.
See 'docker run --help'.

I found the related commit:
moby/moby@27bd684

const extName = "LogDriver"

Hope this PR is useful for those who find this repo.

Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
@cpuguy83 cpuguy83 merged commit 94504ed into cpuguy83:master Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants