Redundant_catch refactored #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravij
previously approved these changes
Jul 29, 2020
|
@acheshkov @lyriccoder I have finished the task, so please take additional look and merge if it is ok. |
lyriccoder
requested changes
Jul 29, 2020
| @@ -104,4 +104,4 @@ def test_fake_try_in_lambda(self): | |||
| """ | |||
| pattern = RedundantCatch() | |||
| lines = pattern.value(os.path.dirname(os.path.realpath(__file__)) + '/Cache.java') | |||
| self.assertEqual(lines, []) | |||
| self.assertEqual(lines, [393]) | |||
There was a problem hiding this comment.
no, it's wrong behaviour. W have lambda. There is no another way to handle exception in lambda. There was a test to check that. If we have try in lambda, we should ignore it
There was a problem hiding this comment.
@lyriccoder I FIXED IT!
aravij
approved these changes
Jul 29, 2020
|
@rultor merge |
|
@rultor why not merging? |
@acheshkov OK, I'll try to merge now. You can check the progress of the merge here |
@acheshkov Done! FYI, the full log is here (took me 30min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved in case of #528
Also test was change because of previous error (you can check the sourse code and make sure that this code structure should be detected too