Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#96: allow markers on contiguous lines #162

Merged
merged 3 commits into from
Jul 14, 2021
Merged

#96: allow markers on contiguous lines #162

merged 3 commits into from
Jul 14, 2021

Conversation

mbao01
Copy link
Contributor

@mbao01 mbao01 commented Jul 12, 2021

Parses these markers correctly ✅

# TODO: #85 Make custom callbacks
# TODO: #85 Check alert messages
# TODO: #85 Refactor methods

// @todo: #85 Another marker
// @todo: #85 Yet another marker

Resolves #96

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 12, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jul 12, 2021

@rultor merge

@mbao01 @yegor256 Oops, I failed. You can see the full log here (spent 3min)

Puzzle 125-7d80a284 30/DEV at lib/pdd/rake_task.rb
Puzzle 125-db127bd1 30/DEV at lib/pdd/rake_task.rb
Reading lib/pdd/sources.rb...
Puzzle 98-9de926c6 30/DEV at lib/pdd/sources.rb
Reading lib/pdd/rule/duplicates.rb...
Reading lib/pdd/rule/text.rb...
Reading lib/pdd/rule/roles.rb...
Reading lib/pdd/rule/estimates.rb...
Reading lib/pdd/puzzle.rb...
Reading lib/pdd/version.rb...
Reading lib/pdd.rb...
Reading appveyor.yml...
Reading assets/puzzles.xsd...
Reading assets/puzzles.xsl...
Reading .rubocop.yml...
Puzzle 123-9786ef4c 30/DEV at .rubocop.yml
Reading .gitignore...
Reading pdd.gemspec...
Reading Gemfile.lock...
Reading features/rake.feature...
Reading features/support/env.rb...
Reading features/gem_package.feature...
Reading features/step_definitions/steps.rb...
Reading bin/pdd...
Reading .gitattributes...
+ LC_ALL=US-ASCII
+ bundle exec rake
/home/r/.ruby/gems/minitest-5.5.0/lib/minitest/assertions.rb:413: warning: mismatched indentations at 'ensure' with 'begin' at 404
/home/r/.ruby/gems/minitest-5.5.0/lib/minitest/assertions.rb:452: warning: mismatched indentations at 'ensure' with 'begin' at 437
Run options: --seed 14457

# Running:

\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0mNOT IMPLEMENTED
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[31mERROR\u001b[0m: Puzzle a.txt:1-1 has an estimate of 0 minutes, which is lower than 30 minutes
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[31mF\u001b[0m

\u001b[31mFailure:
TestSource#test_uses_github_login [/home/r/repo/test/test_source.rb:258]:
Expected: "@yegor256"
  Actual: "test"
\u001b[0m

rails test home/r/repo/test/test_source.rb:243

\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

Finished in 0.568276s, 80.9465 runs/s, 186.5289 assertions/s.

46 runs, 106 assertions, 1 failures, 0 errors, 0 skips
Coverage report generated for Unit Tests to /home/r/repo/coverage. 304 / 309 LOC (98.38%) covered.
rake aborted!
Command failed with status (1)
/home/r/.ruby/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `eval'
/home/r/.ruby/bin/ruby_executable_hooks:24:in `<main>'
Tasks: TOP => default => test
(See full trace by running task with --trace)
container dc18a0741749d306f056fc9ce080bb6f7b5958d3275c8c8f2eace2044cfd78cd is dead
Mon Jul 12 05:38:49 CEST 2021

@yegor256
Copy link
Member

@mbao01 the same bug with GitHub requests limitations?

@mbao01
Copy link
Contributor Author

mbao01 commented Jul 12, 2021

Yes @yegor256 I think the way to go is to mock all API request for tests

@mbao01
Copy link
Contributor Author

mbao01 commented Jul 12, 2021

@yegor256 Now I have stubbed the method that calls github API. Please review

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 14, 2021

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e2362a0 into cqfn:master Jul 14, 2021
@rultor
Copy link
Collaborator

rultor commented Jul 14, 2021

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@yegor256
Copy link
Member

@mbao01 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdd does not recognize my puzzle
4 participants