Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for Dashing #478

Closed

Conversation

rotu
Copy link

@rotu rotu commented Aug 9, 2019

Declare parameters
Name transform listener node to prevent node name collision
Reuse executor (rclcpp::spin_some creates an executor, which takes 36 ms, causing significant issues).

@SteveMacenski
Copy link
Collaborator

Does this substantively different than what's in #476 ? I see alot of the same "stuff" in different places.

Only off hand review question beyond trying to rectify these PRs together is I see you've hardcoded odom0 and imu0, that needs to not be like that. One of the benefits of r_l is that it is generalized enough to handle N sources

@rotu
Copy link
Author

rotu commented Aug 9, 2019

@SteveMacenski It's pretty similar, though that PR looks like it may be in a better state.
I'm ambivalent which one should be merged in.

@cottsay did most of the work on this one, so I already feel a little weird creating a PR of someone else's work.

@rotu
Copy link
Author

rotu commented Aug 9, 2019

yielding to #476. I'll make any needed changes on top of that PR.

@rotu rotu closed this Aug 9, 2019
@SteveMacenski
Copy link
Collaborator

@rotu eh, he works for open robotics, I think its ok ;-) they're busy enough.

If this adds something more to that PR says so and we can work out a plan to integrate, just from a quick scan it seemed similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants