Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index template cleanup #2

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Index template cleanup #2

merged 1 commit into from
Sep 27, 2018

Conversation

panoptican
Copy link
Contributor

  • Since you aren't using that bold/italic webfont, you might as well leave it out to save on loading.
  • Still had transitions on the glyphs so removed those. Don't want anyone thinking you know about CSS transitions. Next thing you know, they'll be asking you to make a CSS Karl.

- Since you aren't using that bold/italic webfont, you might as well leave it out to save on loading.
- Still had transitions on the glyphs so removed those. Don't want anyone thinking you know about CSS transitions. Next thing you know, they'll be asking you to make a [CSS Karl](https://codepen.io/Wujek_Greg/pen/EpJwaj).
@panoptican
Copy link
Contributor Author

And nice work updating the template file. Was going to say that it should be pretty easy...

@craffel
Copy link
Owner

craffel commented Sep 27, 2018

Thanks Jason.

Since you aren't using that bold/italic webfont, you might as well leave it out to save on loading.

So if I end up having a

<b><i>something</i></b>

somewhere on my page someday, will the browser be smart enough to make it bold-italic on its own? Or should I add the webfont back in if that ever happens?

I also realized I don't need the style.css file anymore, right?

@panoptican
Copy link
Contributor Author

You could add it back, but it would also just work. And yeah, you can ditch the style.css file.

@craffel craffel merged commit 86fd46f into craffel:master Sep 27, 2018
@craffel
Copy link
Owner

craffel commented Sep 27, 2018

Merged, thanks Jason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants