Skip to content

Commit

Permalink
[CR] matplotlib modernization (#380)
Browse files Browse the repository at this point in the history
* hacking toward display revisions, not yet finished but want to test on old builds before moving forward

* fixed #332, pitch contour sonification supports nans (#379)

* fixing up test fixtures

* correcting fixture names and paths for display

* fixing separation

* toward a working implementation of axes weakkeydict storage

* updated mpl regression tests for labeled intervals

* fixing up ticks and margins

* updated hierarchy fixtures

* revised separation display to use property cyclers

* working through some matplotlib hackery

* almost done modernizing mpl code...

* very nearly done modernizing

* docs and styling

* rewrote segments to use axvspans

* blacked tests

* skip segment with text plot tests on old matplotlib

* blacked tests

* skip certain tests when using old versions of freetype
  • Loading branch information
bmcfee committed May 13, 2024
1 parent 6b82dde commit 485a425
Show file tree
Hide file tree
Showing 47 changed files with 408 additions and 178 deletions.
350 changes: 243 additions & 107 deletions mir_eval/display.py

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion setup.cfg
@@ -1,5 +1,5 @@
[tool:pytest]
addopts = --cov-report term-missing --cov mir_eval --cov-report=xml
addopts = --cov-report term-missing --cov mir_eval --cov-report=xml --mpl --mpl-baseline-path=baseline_images/test_display

[pydocstyle]
# convention = numpy
Expand Down
Binary file removed tests/baseline_images/test_display/events.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed tests/baseline_images/test_display/piano_roll.png
Binary file not shown.
Binary file not shown.
Binary file removed tests/baseline_images/test_display/pitch_hz.png
Binary file not shown.
Binary file removed tests/baseline_images/test_display/pitch_midi.png
Binary file not shown.
Binary file removed tests/baseline_images/test_display/pitch_midi_hz.png
Binary file not shown.
Binary file removed tests/baseline_images/test_display/segment.png
Binary file not shown.
Binary file removed tests/baseline_images/test_display/segment_text.png
Binary file not shown.
Binary file removed tests/baseline_images/test_display/separation.png
Binary file not shown.
Binary file not shown.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Diff not rendered.

0 comments on commit 485a425

Please sign in to comment.