Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chroma transcription metrics #232

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Chroma transcription metrics #232

wants to merge 10 commits into from

Conversation

chf2117
Copy link

@chf2117 chf2117 commented Jan 9, 2017

Implements and tests #197

@craffel
Copy link
Owner

craffel commented Jan 9, 2017

Thanks Caleb. Apart from PEP8 stuff, you'll also need to add separate evaluation for chroma metrics to mir_eval.transcription.evaluate, e.g. forcing the value of chroma in the kwargs dict to be True, then False, so that both are evaluated (right @justinsalamon)?

Do we have any implementations to test this against? It's a small enough change that I am ok with not testing it against something existing, though we should be very certain in its correctness then :)

@justinsalamon
Copy link
Collaborator

Thanks Caleb. Apart from PEP8 stuff, you'll also need to add separate evaluation for chroma metrics to mir_eval.transcription.evaluate, e.g. forcing the value of chroma in the kwargs dict to be True, then False, so that both are evaluated (right @justinsalamon)?

yes

Do we have any implementations to test this against?

yes, see here.

@chf2117
Copy link
Author

chf2117 commented Jan 9, 2017

yes, see here.

The music-ir link is dead for me. Do you know of any others?

@justinsalamon
Copy link
Collaborator

The music-ir link is dead for me. Do you know of any others?

The MIREX website is temporarily down, my understanding is that they're working on it. I'll check if I have the result files stored locally somewhere, otherwise we'll have to wait till it's back up.

@craffel
Copy link
Owner

craffel commented Feb 27, 2017

Now that the MIREX website is back up, can we move forward on this?

@chf2117
Copy link
Author

chf2117 commented Feb 28, 2017

Yes, I'll try to wrap it up in the next couple days

@chf2117
Copy link
Author

chf2117 commented Jun 11, 2017

I'm a bit confused about comparing to MIREX results. The existing output*.json files don't match the differences from this comment, so I'm not sure what to look for when comparing the results.

@craffel
Copy link
Owner

craffel commented Jul 24, 2017

I'm a bit confused about comparing to MIREX results. The existing output*.json files don't match the differences from this comment, so I'm not sure what to look for when comparing the results.

@justinsalamon can you provide some guidance here?

@bmcfee
Copy link
Collaborator

bmcfee commented Jan 29, 2018

Bumping this one, since it seems like everyone disappeared after summer?

@TGabor
Copy link

TGabor commented Apr 21, 2020

Is it still planned to integrate this functionality and does anybody know which points are still open?

@craffel
Copy link
Owner

craffel commented Apr 21, 2020

This needs to be picked up again. I don't think anyone is planning on doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants