Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/113 field UI language #123

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Aug 1, 2023

Description

  • field’s base config now translates nn language code to no code (CKEditor has no and nb translation files)
  • added translations/nn/ckeditor.php file, which is a copy of the nb translations as a starting point
  • added functionality that respects cke config language setting and registers corresponding native CKEditor translation files; therefore, it’s now possible to have the app language set to nb but choose to use more complete no language for the CKEditor-provided translations; (it’s now also possible to have 2 cke fields in one entry and have one of them have the UI in, e.g. English and another in, e.g. French)
Screenshot 2023-08-01 at 15 42 39

Related issues

#113

@i-just i-just marked this pull request as ready for review August 2, 2023 06:35
@brandonkelly brandonkelly merged commit 957423f into main Aug 11, 2023
5 checks passed
@brandonkelly brandonkelly deleted the bugfix/113-field-ui-language branch August 11, 2023 23:29
@brandonkelly
Copy link
Member

I removed the field config language checks, because that wouldn’t apply to any other CKEditor asset bundles that get registered via plugins. There also wasn’t any point in loading a language file based on $config['language']['content'], as that only defines the language that the content is being produced for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants