Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable "orientation" does not exist. #10044

Closed
seandelaney opened this issue Nov 2, 2021 · 13 comments
Closed

Variable "orientation" does not exist. #10044

seandelaney opened this issue Nov 2, 2021 · 13 comments
Labels

Comments

@seandelaney
Copy link

seandelaney commented Nov 2, 2021

Description

Upgraded from 3.7.16 to 3.7.18.2 and now cannot access any entry.

Upgrade went fine. No issues.

I read in the changelog, that orientation option was added. See: https://github.com/craftcms/cms/blob/main/CHANGELOG.md#changed-2

I've cleared cache, wiped storage/runtime folder.

I'm unable to get around this issue.

Screenshot 2021-11-02 at 10 18 32

Additional info

  • Craft version: 3.7.18.2
  • PHP version: 7.4.3
@seandelaney seandelaney added the bug label Nov 2, 2021
@andris-sevcenko
Copy link
Contributor

@seandelaney Do you have any 3rd party field types installed?

@seandelaney
Copy link
Author

seandelaney commented Nov 2, 2021

@andris-sevcenko

@seandelaney Do you have any 3rd party field types installed?

I'm using:

  • Redactor
  • Super Table
  • Preparse Field
  • SEO Settings (from SEOMatic)
  • oEmbed
  • VZ URL
  • Position Fieldtype

All plugins are using their latest versions.

@andris-sevcenko
Copy link
Contributor

Can you look a bit further in the stacktrace and see if it's easy to get an idea where the error is coming from?

@seandelaney
Copy link
Author

@andris-sevcenko I've already looked through the error stack and saw nothing that stood out.

Will look again.

@andris-sevcenko
Copy link
Contributor

@seandelaney that's strange. Can you verify that you have the following line present in code?
84ab680#diff-66d7197e2f3aaa2d815c1015766ea6850213fc682f3795c21e043c4fdb0a189fR229

@seandelaney
Copy link
Author

@andris-sevcenko

Can you verify that you have the following line present in code?

Yes, I have that line but I also found this, so winder if its the SEOMatic plugin field type:
Screenshot 2021-11-02 at 12 36 31

@andris-sevcenko
Copy link
Contributor

Do you also, by any chance, have Overflow installed?

@brandonkelly
Copy link
Member

Is seoTitle a custom field?

@seandelaney
Copy link
Author

seandelaney commented Nov 2, 2021

Screenshot 2021-11-02 at 13 12 25

Its an Overflow field, but literally just found where it was coming from:

https://github.com/experience/overflow.craft-plugin/issues

Closing this issue since I think its plugin related. See culprit from said plugin:

/**
     * @inheritdoc
     */
    public function getInputHtml($value, ElementInterface $element = null): string
    {
        $this->registerInputHtmlAssets();
        $this->registerInputHtmlJs();

        return Craft::$app->getView()->renderTemplate('_components/fieldtypes/PlainText/input', [
            'id'    => Craft::$app->getView()->formatInputId($this->handle),
            'name'  => $this->handle,
            'value' => $value,
            'field' => $this,
        ]);
    }

brandonkelly added a commit that referenced this issue Nov 2, 2021
@brandonkelly
Copy link
Member

Aha. Well they shouldn’t be using the Plain Text field’s internal input template. But it’s an easy fix, so I’ve just patched it on Craft’s end.

To get the fix early, change your craftcms/cms requirement in composer.json to "dev-develop as 3.7.18.2" and run composer update.

brandonkelly added a commit that referenced this issue Nov 2, 2021
@brandonkelly
Copy link
Member

(Sorry, previous commit didn’t include the actual fix accidentally. Definitely fixed now.)

@seandelaney
Copy link
Author

I can confirm, patch has fixed the issue.

I've pinged the Experience plugin developer to update at his end too.

Thanks guys!

@brandonkelly
Copy link
Member

Craft 3.7.19 is out now with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants