Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Field Layout Editor, UI Elements with Entry Conditions lack a dashed border [4.x]: #12250

Closed
mike-moreau opened this issue Nov 2, 2022 · 5 comments
Assignees

Comments

@mike-moreau
Copy link

What happened?

Description

Seeing that fields with conditions have a dashed border, I expected UI Elements with conditions (a template in this case) to have a similar border as well.

Steps to reproduce

  1. Add a template UI element with an entry condition

Expected behavior

Expected design to indicate UI element was conditional.

Actual behavior

Appears like other UI elements.

Screen Shot 2022-11-02 at 9 46 53 AM

Screen Shot 2022-11-02 at 9 47 00 AM

Craft CMS version

4.3.1

PHP version

8.1

Operating system and version

Mac OS

Database type and version

MySQL 5.7

Image driver and version

No response

Installed plugins and versions

  • Neo
@mike-moreau mike-moreau changed the title In Field Layout Editor, UI Elements with Entry Conditions lack a dshed border [4.x]: In Field Layout Editor, UI Elements with Entry Conditions lack a dashed border [4.x]: Nov 2, 2022
@mike-moreau
Copy link
Author

I forced a black background and hmm, actually looks like it has the border, it's just white-on-white so not visible.

Screen Shot 2022-11-02 at 10 08 11 AM

@i-just i-just self-assigned this Nov 3, 2022
brandonkelly added a commit that referenced this issue Nov 7, 2022
@brandonkelly
Copy link
Member

Resolved this for Craft 4.4: the dashed border has been replaced with a new condition icon, which will sit beside layout component labels (similar to the field-required icon). Advantage of going this route is that we can also use it to identify conditional tabs:

Two configured tabs within a field layout designer, highlighting the new condition icon on a UI element, a field, and a tab.

@mike-moreau
Copy link
Author

Great, thank you!

@brandonkelly
Copy link
Member

4.4 is out with that change!

@mike-moreau
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants