Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update money field to use label-referenced ID and describedBy variable #11016

Closed
wants to merge 12 commits into from

Conversation

gcamacho079
Copy link
Contributor

Description

Implements getInputId function on Money field class to set an ID that matches the one referenced by the label's for attribute, and passes the field describedBy variable to the field template.

Related issues

Resolves DEV-516
Closes #11011

@linear
Copy link

linear bot commented Apr 26, 2022

DEV-516 Money field does have accessible label, or reference instructions, errors, etc. in an aria-describedby attribute

Money field label does not reference correct ID, and doesn't include an aria-describedby attribute

Add prefix to the label ID, and utilize the describedBy variable

Screen Shot 2022-04-18 at 2.51.27 PM.png

Screenshot shoes label for attribute doesn't match input ID

Resolves CMS-163

@brandonkelly brandonkelly deleted the branch 4.0 May 4, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants