Feature/disable preview button during save

[brianjhanson]

Description

Disables the preview button while a draft is saving in order to prevent the wrong field layout from showing when the preview opens.

Related issues

• Resolves [4.x]: Wrong field layout for preview if changing entry types and opening preview before provisional draft is done saving #11858

[gcamacho079]

@brianjhanson nice update! Just one change I'd like to suggest:

• For screen reader accessibility, the aria-disabled attribute is preferred over disabled. It requires the extra step of preventing clicks programmatically, but is otherwise a usability improvement since screen reader users are alerted that the button is there, just inactive at the moment.

I was torn about whether the disabled state should be applied to the button immediately upon saving instead of on Preview click — and having the disablePreviewButton called with the beforeRun event — but I do see the benefit of keeping it clickable while the new layout is loading.

[brianjhanson]

Thanks @gcamacho079! I ended up removing the event listeners when the preview button is disabled but I'm not sure if that's going too far. Let me know if there's a better way to disable programatic clicks.

[gcamacho079]

Looks good, @brianjhanson. An alternative to adding/removing the click listener would be to immediately exit the openPreview function if the button already has the aria-disabled attribute.

[brandonkelly]

An alternative to adding/removing the click listener would be to immediately exit the openPreview function if the button already has the aria-disabled attribute.

That feels a little safer to me.

[brianjhanson]

@brandonkelly just pushed up that change