disallow forwards slashes in slugs #12874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just added a little protection to swap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disallows forward slash in slugs when saving an element.
I’m torn between this approach and a more drastic version where we check if the
slugWordSeparatoris set to/on getting the general config (similar to how we check thesecurityKey).On the one hand, the approach in this PR should provide better backward compatibility on the off-chance that someone was using
/as a slug word separator. It would still allow it in, e.g. autogenerated entry URI format on section creation.On the other hand, throwing an exception on getting the general config is a more robust way of seriously disallowing
/.@brandonkelly, when you have a second, could you please LMK your thoughts?
Related issues
#12871