Make local volumes respect defaultFileMode and defaultDirMode

[jeffturcotte]

This patch makes Local volumes respect the defaultFileMode and defaultDirMode config settings by passing them into the Flysystem adapter. The documentation reads as if this was the intended behavior.

When a mode isn't set, it defaults back to what Flysystem uses internally: 0755 and 0644.

I couldn't find any existing reports regarding this issue.

Thanks!

[jeffturcotte]

Any thoughts on this yet? We are currently using a somewhat-hacky module to get around this limitation: https://github.com/imarc/craft-volume-permissions. We had to use Reflection to access and modify the Flysystem defaults.

Without the ability to set the proper default file permissions for the local volume adapter, Craft will not play nicely in hosting environments using filesystem ACLs, which almost always requires having a group writable permission.

Thanks.

[andris-sevcenko]

Ugh. Sorry. GitHub really needs to remind about inactive pull requests. Or, you know, maybe I shouldn't forget about stuff.

I just set a reminder to merge this in on Monday. Sorry again - I completely dropped the ball on this.

[jeffturcotte]

No worries @andris-sevcenko. Thank you!

[andris-sevcenko]

Thank you for your patience!

[brandonkelly]

Craft 3.4.23 is out now with this change.