Fixed store management menu on stores index not showing all items

craftcms · May 16, 2024 · 33b8cf3 · 33b8cf3
1 parent cabc764
commit 33b8cf3
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 25 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release Notes for Craft Commerce
 
+## Unreleased
+
+- Fixed a bug where the store management menu was not listing all items on the Stores index page.
+
 ## 5.0.6 - 2024-05-15
 
 - Fixed an error that occurred when deleting or duplicating a shipping rule on the Edit Shipping Rule screen. ([#3490](https://github.com/craftcms/commerce/issues/3490))

diff --git a/src/controllers/StoresController.php b/src/controllers/StoresController.php
@@ -217,11 +217,71 @@ public function actionStoresIndex(): Response
             ],
         ];
 
+        $menuItems = [];
+        $stores->each(function(Store $s) use (&$menuItems) {
+            $m = [];
+            $m[] =  [
+                'label' => Craft::t('commerce', 'Payment Currencies'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/payment-currencies'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Discounts'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/discounts'),
+            ];
+
+            if (Plugin::getInstance()->getCatalogPricingRules()->canUseCatalogPricingRules()) {
+                $m[] = [
+                    'label' => Craft::t('commerce', 'Pricing Rules'),
+                    'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/pricing-rules'),
+                ];
+            } else {
+                $m[] = [
+                    'label' => Craft::t('commerce', 'Sales'),
+                    'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/sales'),
+                ];
+            }
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Shipping Methods'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/shippingmethods'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Shipping Zones'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/shippingzones'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Shipping Categories'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/shippingcategories'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Tax Rates'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/taxrates'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Tax Zones'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/taxzones'),
+            ];
+
+            $m[] = [
+                'label' => Craft::t('commerce', 'Tax Categories'),
+                'url' => UrlHelper::cpUrl('commerce/store-management/' . $s->handle . '/taxcategories'),
+            ];
+
+            $menuItems[$s->handle] = $m;
+        });
+
+
         return $this->renderTemplate('commerce/settings/stores/index', [
             'stores' => $stores,
             'crumbs' => $crumbs,
             'sitesStores' => Plugin::getInstance()->getStores()->getAllSiteStores(),
             'primaryStoreId' => Plugin::getInstance()->getStores()->getPrimaryStore()->id,
+            'menuItems' => $menuItems,
         ]);
     }
 

diff --git a/src/templates/settings/stores/index.twig b/src/templates/settings/stores/index.twig
@@ -34,30 +34,6 @@
 
 {% set tableData = [] %}
 {% for store in stores %}
-
-    {% set menuItems = [
-        {
-            label: 'Payment Currencies'|t('commerce'),
-            url: url('commerce/store-management/' ~ store.handle ~ '/payment-currencies'),
-        },
-        {
-            label: 'Discounts'|t('commerce'),
-            url: url('commerce/store-management/' ~ store.handle ~ '/discounts'),
-        },
-        {
-            label: 'Pricing Rules'|t('commerce'),
-            url: url('commerce/store-management/' ~ store.handle ~ '/pricing-rules'),
-        },
-        {
-            label: 'Shipping Methods'|t('commerce'),
-            url: url('commerce/store-management/' ~ store.handle ~ '/shippingmethods'),
-        },
-        {
-            label: 'Tax Rates'|t('commerce'),
-            url: url('commerce/store-management/' ~ store.handle ~ '/taxrates'),
-        }
-    ] %}
-
     {% set tableData = tableData|merge([{
         id: store.id,
         name: store.name|t('site'),
@@ -73,7 +49,7 @@
             menuBtnTitle: ''|t('app'),
             label: 'Store Management    '|t('commerce'),
             url: url('commerce/store-management/' ~ store.handle),
-            items: menuItems,
+            items: menuItems[store.handle],
         },
         _showDelete : store.primary ? false : true
     }]) %}