Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP error when creating a new Shipping/Tax Zone without any selected Countries/States #19

Closed
brandonkelly opened this issue Oct 10, 2016 · 1 comment
Closed

PHP error when creating a new Shipping/Tax Zone without any selected Countries/States #19

brandonkelly opened this issue Oct 10, 2016 · 1 comment
Assignees
@lukeholder
Labels
bug

Comments

@brandonkelly
Copy link
Member

Steps to reproduce:

  1. Create a new Tax Zone
  2. Give it a Name and Handle, but don't assign any countries or states to it
  3. Save

Rather than reloading the page with a validation error on the Countries/States field, you get a PHP warning:

reset() expects parameter 1 to be array, string given

Also affects Shipping Zones.
@brandonkelly brandonkelly added this to the 2.1 milestone Oct 10, 2016
lukeholder added a commit that referenced this issue Oct 11, 2016
@lukeholder
Fix validation issues with tax and shipping zones
4d50f30 
Fixes #18 and #19
@lukeholder
Copy link
Member

Fixed in 4d50f30

brandonkelly pushed a commit that referenced this issue Oct 29, 2018
@lukeholder
Merge pull request #19 from billythekid/patch-2
7c82076 
redirect field helper syntax for craft3
@gjhead gjhead mentioned this issue Nov 2, 2018
Closed
@ghost ghost mentioned this issue Jun 25, 2019
Closed
@james-kennedy-krill james-kennedy-krill mentioned this issue Apr 7, 2020
Closed
@samhibberd samhibberd mentioned this issue Jun 26, 2020
Closed
@maximilian-schwarz maximilian-schwarz mentioned this issue Jul 15, 2020
Closed
@brambeekman brambeekman mentioned this issue Jul 24, 2021
Closed
@carolineboeykens carolineboeykens mentioned this issue Jan 6, 2022
Closed
@philipboomy philipboomy mentioned this issue Sep 6, 2022
Closed
@philipboomy philipboomy mentioned this issue Jan 11, 2024
Closed
gopeter pushed a commit to evernow-io/craft-commerce that referenced this issue Apr 5, 2024
@nfourtythree
Merge pull request craftcms#19 from pixelandtonic/feature/gateways-pe…
5217b25 
…r-store

Gateways per store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukeholder lukeholder

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonkelly @lukeholder