Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Times Coupon Used" should work even when there's no total coupon use limit #521

Closed
benface opened this issue Oct 5, 2018 · 5 comments
Closed
Assignees
Labels
Milestone

Comments

@benface
Copy link

benface commented Oct 5, 2018

When creating a discount with a coupon, the description for the "Times Coupon Used" field reads:

How many times this coupon has been used, if a total coupon usage limit has been set.

It would be helpful if this field indicated how many times the coupon has been used regardless of whether a total coupon use limit has been set.

@DarrylHardin
Copy link
Contributor

Is that not how it is? That's how I read it as well

@benface
Copy link
Author

benface commented Oct 5, 2018

No, I can confirm that at the moment, it only counts uses if “total coupon uses limit” is > 0 (0 being unlimited).

@lukeholder lukeholder added the 💡 enhancement Ideas and suggestions label Oct 10, 2018
@tobyjug
Copy link

tobyjug commented Feb 5, 2019

I've just had a client complain about this. It would be very useful for a client to know how many times a coupon has been used regardless of the limit.

@nfourtythree
Copy link
Contributor

Hey @benface and @importantcoding

I have pushed an update to fix this behaviour. We are also looking to update how this works in 3.0 #1059

This functionality will be included in 2.2.

@nfourtythree
Copy link
Contributor

Also /cc @tobyjug, sorry for forgetting to tag you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants