Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compatibility with Google Maps plugin v4.3+ #1245

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

lindseydiloreto
Copy link
Contributor

Description

Patches a compatibility issue with the Google Maps plugin (if using GM v4.3+).

NOTE: If patching an existing feed, it may be necessary to remap the Address subfields.

Related issues

doublesecretagency/craft-googlemaps#78

@zizther
Copy link

zizther commented Feb 26, 2023

I can confirm this PR fixes the issue with GM 4.3+
I had to remap the fields after updating.

Would be great to get this into Feed Me to support the latest versions of the Google Maps plugin

@lindseydiloreto
Copy link
Contributor Author

@zizther Excellent, thank you for confirming! 👍

@angrybrad angrybrad changed the base branch from main to develop March 7, 2023 01:35
@angrybrad angrybrad merged commit 695df59 into craftcms:develop Mar 7, 2023
@angrybrad
Copy link
Member

Thanks!

angrybrad added a commit that referenced this pull request Mar 7, 2023
@lindseydiloreto
Copy link
Contributor Author

Excellent, thanks @angrybrad! 🍺

@brandonkelly
Copy link
Member

Feed Me 5.1.0 has been released with this change.

@lindseydiloreto
Copy link
Contributor Author

Fantastic, thanks @brandonkelly! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants