Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict_types by default #29

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

Jensderond
Copy link
Contributor

Description

This PR just adds declare(strict_types=1); to each generated php file.

@brandonkelly brandonkelly merged commit 6a3d7c0 into craftcms:main Mar 6, 2024
@brandonkelly
Copy link
Member

Thanks for the PR! We decided not to have this be the default behavior, but I added a --with-strict-types flag that you can pass if you want it.

Generator 1.7.0 is tagged with that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants