Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[studio-ui] preview-server url should be read from a single location #2617

Closed
russdanner opened this issue Nov 8, 2018 · 13 comments
Closed

[studio-ui] preview-server url should be read from a single location #2617

russdanner opened this issue Nov 8, 2018 · 13 comments
Assignees
@russdanner
Labels
enhancement priority: high
Milestone
Crafter CMS v3.0.21

Comments

@russdanner
Copy link
Member

russdanner commented Nov 8, 2018 •
edited by sumerjabri
Loading

Expected behavior

Any aspect of Studio that needs to look up the preview server location should do so from a single location.

To be consistent with other configuration tickets:
Please remove the preview-server tag in config/studio/site-config.xml as a source of the preview server location/URL for a given site and use the one in config/studio/environment-config/environment.xml as the sole source of truth. There should no longer be any blueprints/code that uses config/studio/site-config.xml

Actual behavior

Preview window uses: config/studio/site-config.xml
Other components like the form engine use config/studio/environment-config/environment.xml

Specs

Version

Studio Version Number: 3.0.18-SNAPSHOT-c83d09
Build Number: c83d093236093940482d6fc2b3c719e46344278a
Build Date/Time: 10-26-2018 11:42:55 -0400
@russdanner russdanner added this to the Crafter CMS v3.0.19 milestone Nov 8, 2018
@sumerjabri sumerjabri assigned vestrada and unassigned jdrossl Nov 26, 2018
@sumerjabri sumerjabri changed the title [studio] preview-server url should be read from a single location [studio-ui] preview-server url should be read from a single location Nov 26, 2018
vestrada added a commit to vestrada/studio that referenced this issue Nov 28, 2018
@vestrada
craftercms/craftercms#2617 - [studio-ui] preview-server url should be…
e9515b2 
… read from a single location craftercms#2617
@vestrada vestrada mentioned this issue Nov 28, 2018
Merged
@vestrada
Copy link

studio -> 3.1 - > craftercms/studio#1372

vestrada added a commit to vestrada/studio that referenced this issue Nov 28, 2018
@vestrada
craftercms/craftercms#2617 - [studio-ui] preview-server url should be…
22f2339 
… read from a single location craftercms#2617
@vestrada vestrada mentioned this issue Nov 28, 2018
Merged
@vestrada
Copy link

studio -> 3.0 - > craftercms/studio#1373

vestrada added a commit to vestrada/studio-ui that referenced this issue Nov 28, 2018
@vestrada
craftercms/craftercms#2617 - [studio-ui] preview-server url should be…
501f97f 
… read from a single location craftercms#2617
@vestrada vestrada mentioned this issue Nov 28, 2018
Merged
@vestrada
Copy link

studio-ui -> 3.1 - > craftercms/studio-ui#996

vestrada added a commit to vestrada/studio-ui that referenced this issue Nov 28, 2018
@vestrada
craftercms/craftercms#2617 - [studio-ui] preview-server url should be…
5c78b76 
… read from a single location craftercms#2617
@vestrada vestrada mentioned this issue Nov 28, 2018
Merged
@vestrada
Copy link

studio-ui -> 3.0 - > craftercms/studio-ui#997

@vestrada vestrada assigned russdanner and unassigned vestrada Nov 28, 2018
@russdanner
Copy link
Member Author

russdanner commented Nov 30, 2018 •
edited
Loading

@vita this ticket will impact blueprint example configuration and upgrade instructions in release notes.
If you were using Site Configuration: <previewServer>http://localhost:3000</previewServer>
You should remove it and instead configure Environment Configuration <preview-server-url>http://localhost:3000</preview-server-url>

@russdanner
Copy link
Member Author

Confirmed

This was referenced Jan 17, 2019
Closed
Merged
Merged
@dejan-brkic
Copy link
Member

3.0: craftercms/studio#1439

3.1: craftercms/studio#1440

@dejan-brkic dejan-brkic mentioned this issue Jan 17, 2019
Merged
@russdanner russdanner reopened this Jan 22, 2019
@russdanner
Copy link
Member Author

russdanner commented Jan 22, 2019 •
edited
Loading

@dejan-brkic
studio.configuration.site.defaultPreviewUrl should be hard coded to port 8080.
Update default value for this parameter to:
studio.configuration.site.defaultPreviewUrl: ^https?://localhost:8080/?

@russdanner russdanner assigned dejan-brkic and unassigned russdanner Jan 22, 2019
@russdanner
Copy link
Member Author

russdanner commented Jan 22, 2019 •
edited
Loading

Workaround:

The easiest workaround to this bug is to use <preview-server>http://127.0.0.1:9090/</preview-server> in your site's environment configuration.

The other workaround is to edit CRAFTER/bin/apache-tomcat/shared/classes/crafter/studio/extension/studio-config-override.yaml
Add the following line and restart your Crafter Studio Server
studio.configuration.site.defaultPreviewUrl: ^https?://localhost:8080/?

@dejan-brkic dejan-brkic mentioned this issue Jan 22, 2019
Merged
@dejan-brkic
Copy link
Member

dejan-brkic commented Jan 22, 2019 •
edited
Loading

Done
PR:
craftercms/studio#1446
craftercms/studio#1447

@dejan-brkic dejan-brkic mentioned this issue Jan 22, 2019
Merged
@russdanner
Copy link
Member Author

Confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russdanner russdanner

Labels
enhancement priority: high
Projects
None yet
Milestone
Crafter CMS v3.0.21
Development

No branches or pull requests
5 participants
@russdanner @jdrossl @sumerjabri @dejan-brkic @vestrada