Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Griefers might be able to close gates by breaking protected gate frame blocks #25

Closed
t-unit opened this issue Jul 9, 2013 · 5 comments
Labels

Comments

@t-unit
Copy link
Member

t-unit commented Jul 9, 2013

When using WorldGuard players without permission breaking a gate frame block cause gates to get closed. See this comment.

@ghost ghost assigned t-unit Jul 9, 2013
@t-unit
Copy link
Member Author

t-unit commented Jul 10, 2013

This is not an issue when using GriefPrevention.

@ddidderr
Copy link
Member

I had a look at the source codes of GriefPrevention, WorldGuard and of course Craft Inc. Gates.

It's definitely a problem with the event priorities in WorldGuard. Bukkit Wiki states "if you want to change the outcome of an event, choose very carefully from LOWEST to HIGHEST. Suggested generalized protection plugins on lowest, more specific plugins on normal, and override plugins on high." (see here)

WorldGuard however is using HIGH as event priority. See here

GriefPrevention does it right and uses LOWEST. See here

Craft Inc. Gates uses NORMAL, which should be right. So what happens is, Craft Inc. Gates gets the event prior to WorldGuard, checks if it was cancelled, no it wasn't because WorldGuard did not get the event yet, so Craft Inc. Gates does what it does and disables the gate because a frame block was destroyed. After all that WorldGuard begins to check that this block should have never been broken and cancels the event. So I suppose filing a bug at the WorldGuard issue tracker would be the correct and only solution.

I actually think there must be a lot more plugins which do things on BlockBreakEvents and they all must experience problems with WorldGuard.

@ddidderr
Copy link
Member

I found the issue in the WorldGuard bug tracker!

http://youtrack.sk89q.com/issue/WORLDGUARD-2784

@t-unit
Copy link
Member Author

t-unit commented Jul 10, 2013

This is definitely a problem of WorldGuard and not of Craft Inc. Gates.

Changed to won't fix and closed.

@t-unit t-unit closed this as completed Jul 10, 2013
@t-unit
Copy link
Member Author

t-unit commented Jul 10, 2013

On second thought many protection plugins might listen to events with high priority. Changing the priority of our block break listener to MONITOR will solve such issues once and for all. (That's ok since we don't actually handling/canceling those events.)

@t-unit t-unit reopened this Jul 10, 2013
t-unit added a commit that referenced this issue Jul 10, 2013
…his will resolve issues with third party protection plugins. See issue #25.
@t-unit t-unit closed this as completed Jul 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants