Better error messaging

craftsmancoding · Nov 20, 2014 · c577d15 · c577d15
1 parent 906bea3
commit c577d15
Show file tree

Hide file tree

Showing 9 changed files with 212 additions and 2 deletions.
diff --git a/.idea/.name b/.idea/.name
diff --git a/.idea/encodings.xml b/.idea/encodings.xml
diff --git a/.idea/misc.xml b/.idea/misc.xml
diff --git a/.idea/modules.xml b/.idea/modules.xml
diff --git a/.idea/modx_utils.iml b/.idea/modx_utils.iml
diff --git a/.idea/scopes/scope_settings.xml b/.idea/scopes/scope_settings.xml
diff --git a/.idea/vcs.xml b/.idea/vcs.xml
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/firehose.php b/firehose.php
@@ -32,7 +32,7 @@ function add_records($args) {
     global $modx;
     for ($i=1; $i <= $args['count'] ; $i++) {  
         $obj = $modx->newObject($args['classname']);
-        $obj->fromArray($args);
+        $obj->fromArray($args); // <--- throw everything at the wall... only real properties should stick
         switch ($args['classname']) {
             case 'modResource':
                 // Set the things that need to be unique
@@ -70,7 +70,14 @@ function add_records($args) {
                 break;
         }
         if (!$obj->save()) {
-            print message("Failed to add a {$args['classname']} Record",'ERROR');
+            $summary = array();
+            $validator = $obj->getValidator();
+            if ($validator->hasMessages()) {
+                foreach ($validator->getMessages() as $message) {
+                    $summary[] = sprintf("\t- field: %s -- \"%s\"\n", $message['field'], $message['message']);
+                }
+            }
+            print message("Failed to add a {$args['classname']} Record\n".implode("\n",$summary),'ERROR');
         }
     }
 }