Fixes incorrect rendering of flipped animation tiles #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blic property that returns the backing field as a ReadOnlySpan.
…MonoGame.Extended into tiled_animation_flip_fix
AristurtleDev
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect rendering of flipped tiles that are animated.
The reason this bug occurred was that when the vertex buffer got updated with the next animation frame texture, it pulled the default orientation instead of the flipped version.
I opted to add a dictionary of the flipped vectors to the animation frames. This dictionary only gets loaded with the necessary orientations of flipped vectors needed for rendering. I thought this was a better option than recalculating all of the necessary flipping in the update loop. This adds a bit more memory overhead, but should run faster.
Feel free to reach out if you have any questions. I have some footage of the before and after I can show if you are interested.