Resolves Infinite Recursion with Shape.Intersects(this IShapeF, IShapeF) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When both params `a` and `b` are of type `RectangleF` just calling `Shape.Intersects` creates a infinite recursion bug.
|
CI Tests are failing due to other bugs in the testing suite. You can run this PR manually to see it resolves the issues in the 
|
7 tasks
|
Going to go ahead and merge this and #854 since these are high priority issues that are blocking the CI from executing tests and getting new NuGets deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the infinite recursion bug in
Shape.Intersects(this IShapeF, IShapeF)when both parameters are of typeRectangleF.Related Issues
ShapeF.Intersects(this IShapeF, IShapeF)Infinite Recursion Bug #850