Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framework target #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eastcoastcoder
Copy link

Having issues building with the newest react-native-windows.
For some reason having a target framework of "uap10.0" is invalid. I instead pointed it at 10586 and my build issues were solved. I think there was some breaking change happening either within react-native's ecosystem or UWP apps since the last sdk release.

@eastcoastcoder
Copy link
Author

See a similar issue I had with RNFS itinance/react-native-fs#447

@craftzdog
Copy link
Owner

Cool!
@hnq90 can you review it?

@hnq90
Copy link
Collaborator

hnq90 commented Feb 21, 2018

@craftzdog @ethanx94 We can approve it after this issue microsoft/react-native-windows#1644 is resolved.

@eastcoastcoder
Copy link
Author

There's actually a better way to do this now.
itinance/react-native-fs@7c5285e

@hnq90
Copy link
Collaborator

hnq90 commented May 2, 2018

@ethanx94 Nice. Could you update your PR?

@eastcoastcoder
Copy link
Author

Well I tried to the same fix but ran into an issue resolving Microsoft.Data.SQLite
I tried adding in 2.0.1 manually with the NuGet package manager but still no luck. Not sure what I'm missing here. I thought just hitting Restore NuGet packages by itself would do the trick. Might need a second opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants