Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stars in Dark background gets something like light border #56

Closed
jd-solanki opened this issue Nov 12, 2019 · 4 comments
Closed

Stars in Dark background gets something like light border #56

jd-solanki opened this issue Nov 12, 2019 · 4 comments

Comments

@jd-solanki
Copy link

Hello,

I have used your star component it is awesome. However, I am getting UI issue when dark background is used.

Please check this image:
dark-bg

I also get white stroke in yellow stars, if size is small. Try changing code for glowing stars in your jsfiddle example to below code.

  <h2>Glowing Stars</h2>
  <div style="background:#000;padding-bottom:10px;">

    <star-rating :star-size="20"></star-rating>
  </div>

Result shade of light grey or white:
glow

I am also getting same in my project which is live. You can check how it looks in below image.
dist

However, this might looks tiny issue but if we use dark theme in our app as eveybody loves now a days it brings this issue.

Awesome Component BTW.
Waiting for your response.

~ Regards

@ivansteff
Copy link

ivansteff commented Dec 17, 2019

+I have same problem

@Aurion72
Copy link

I have it too

@cj4luv
Copy link

cj4luv commented Apr 10, 2020

<polygon :points="starPointsToString" :fill="getGradId" :stroke="glowColor"

this line stroke prop name glowColor

you can set custom color

example
<star-rating :glowColor="#000000"></star-rating>

craigh411 pushed a commit that referenced this issue Sep 25, 2020
- Clearable prop has been added so second click on same rating clears rating
- Removed glow showing even when no glow is set (closes #56 closes #50)
- Tests updated to use vue test util and jest
- Updated webpack
- Updated babel
- Eslint now extends eslint-vue-plugin
@craigh411
Copy link
Owner

Fixed in version 1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants