Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid version specification ‘7’ #16

Closed
pakiessling opened this issue Mar 18, 2023 · 7 comments · Fixed by #18
Closed

invalid version specification ‘7’ #16

pakiessling opened this issue Mar 18, 2023 · 7 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@pakiessling
Copy link

Hi, I installed rspm on Centos 7 via remotes on R 4.2.3 in a Conda enviroment.

Unfortunately I receive the following error:

rspm::enable()
Error: invalid version specification ‘7’

Any ideas?

@Enchufa2
Copy link
Member

Unfortunately, I have no idea, I don't use Conda. As you can see in my workflows, the package is checked for every commit in CentOS 7, 8 and 9, and it works. So this must be some issue in the Conda environment.

@Enchufa2
Copy link
Member

Closing here. Please feel free to reopen if you find there's actually some issue in rspm.

@pakiessling
Copy link
Author

Hi @Enchufa2 I tried again with a fresh R install outside of conda.

I still receive the same error.

cat /etc/os-release output:

NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

How are you probing for os version and is this different from what is returned by my os-release?

@Enchufa2
Copy link
Member

Here's how. It uses /etc/os-release.

@pakiessling
Copy link
Author

@Enchufa2 Thanks

Looks like my id gets correctly set to centos. My os$VERSION_ID gets reported as "7" which throws an error with package_version("7")
I do not know enough about R to tell where the error lies. I guess I will overwrite my integration.R for now

@Enchufa2 Enchufa2 reopened this Mar 25, 2023
@Enchufa2 Enchufa2 added the bug Something isn't working label Mar 25, 2023
@Enchufa2
Copy link
Member

Thanks, that is indeed an issue. I'll fix it and send an update to CRAN ASAP.

Enchufa2 added a commit that referenced this issue Mar 25, 2023
Enchufa2 added a commit that referenced this issue Mar 25, 2023
* test error message for non-supported platforms

* install config-manager in CentOS 8

* explicitly test OS in CI machines

* get version in a safe way, fixes #16

* disable direct rpm unpacking

* bump version, update NEWS

* use expect_match
@Enchufa2
Copy link
Member

On CRAN now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants