Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

Move default values to defines and/or enums #83

Closed
crankycyclops opened this issue Jan 6, 2013 · 1 comment
Closed

Move default values to defines and/or enums #83

crankycyclops opened this issue Jan 6, 2013 · 1 comment
Assignees
@crankycyclops
Labels
cleanup
Milestone
Sprint 9

Comments

@crankycyclops
Copy link
Owner

In parsexml.c, we have a lot of default settings that should exist in defines and/or enums. We should do this asap.
@ghost ghost assigned crankycyclops Jan 6, 2013
crankycyclops pushed a commit that referenced this issue Jan 6, 2013
#83: created #defines for default attribute values
7ba029b
@crankycyclops
Copy link
Owner Author

The following default settings can't be changed until I re-write parsing to use ints instead of strings:

object->weight, object->takeable and object->droppable (lines 504-511 in parsexml.c)

crankycyclops pushed a commit that referenced this issue Jan 6, 2013
#83: set more default values in header files
115534a
crankycyclops pushed a commit that referenced this issue Jan 6, 2013
#83: replaced most default values with defined constants
5a0b7f7
crankycyclops pushed a commit that referenced this issue Jan 6, 2013
#83: finished moving default values to defined constants
4c96f06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crankycyclops crankycyclops

Labels
cleanup
Projects
None yet
Milestone
Sprint 9
Development

No branches or pull requests
1 participant
@crankycyclops