Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial detailed support for Amcor A/C protocol. #854

Merged
merged 4 commits into from
Aug 16, 2019
Merged

Initial detailed support for Amcor A/C protocol. #854

merged 4 commits into from
Aug 16, 2019

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Aug 9, 2019 •
edited
Loading

  • Add checking of checksum to decodeAmcor()
  • Add methods to handle power, mode, temp, max, & fan speed.
  • Add common a/c support.
  • Unit tests for the above.

Fixes #834

@crankyoldgit crankyoldgit self-assigned this Aug 9, 2019
@crankyoldgit crankyoldgit mentioned this pull request Aug 9, 2019
Closed
@crankyoldgit
Copy link
Owner Author

FYI Seems to be working on a real device per #834 (comment)

@crankyoldgit
Initial detailed support for Amcor A/C protocol.
ac32e50 
* Add checking of checksum to `decodeAmcor()`
* Add methods to handle power, mode, temp, & fan speed.
* Add common a/c support.
* Unit tests for the above.

TODO: Determine what "Lo" mode/temp is.

For #834
@crankyoldgit
Fix linter issue.
9b7353a
@crankyoldgit
Amcor: Add set/getMax()
1e011d7 
* Enables the equiv. of 'Hi' and 'Lo' temp settings.
* Unit tests for the above.

Fixes #834
@crankyoldgit
Amcor: Update status
1a67d43
@crankyoldgit crankyoldgit merged commit 77d6c49 into master Aug 16, 2019
@crankyoldgit crankyoldgit deleted the amcor_detailed branch August 16, 2019 02:03
crankyoldgit added a commit that referenced this pull request Aug 28, 2019
@crankyoldgit
v2.6.5 release
8f1461a 
_v2.6.5 (20190828)_

**[Bug Fixes]**
- IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869)
- Fujitsu: Ensure `on()` is called in common a/c framework. (#862)
- Update `strToModel()` (#861)
- IRMQTTServer: Add missing header file. (#858)
- IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856)

**[Features]**
- IRrecv: Allow receive tolerance percentage to be set at run-time. (#865)
- Basic support for Daikin152 A/C protocol. (#874)
- Teco: Add light, humid, & save support. (#871)
- Detailed support for Amcor A/C protocol. (#836, #854)
- IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845)
- Gree: Add timer support. (#849)
- IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844)
- IRMQTTServer: Generate protocol and bit size html selects (#838)

**[Misc]**
- New example code to show how to use the `IRac` class to control A/Cs (#839)
- Improve/fix `swingh_t::kWide` support (#846)
- Kelvinator: Optimise code a little to save space. (#843)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2019
Merged
crankyoldgit added a commit that referenced this pull request Aug 28, 2019
@crankyoldgit
v2.6.5 release (#875)
c01f356 
_v2.6.5 (20190828)_

**[Bug Fixes]**
- IRMQTTServer: Remove duplicate MQTT_CLIMATE from HA discovery (#869)
- Fujitsu: Ensure `on()` is called in common a/c framework. (#862)
- Update `strToModel()` (#861)
- IRMQTTServer: Add missing header file. (#858)
- IRMQTTServer: Fix a compile error when HTML_PASSWORD_ENABLE is enabled. (#856)

**[Features]**
- IRrecv: Allow receive tolerance percentage to be set at run-time. (#865)
- Basic support for Daikin152 A/C protocol. (#874)
- Teco: Add light, humid, & save support. (#871)
- Detailed support for Amcor A/C protocol. (#836, #854)
- IRMQTTServer: Add ability to report Vcc at the ESP chip. (#845)
- Gree: Add timer support. (#849)
- IRac/Mitsubishi A/C: Support wide `swingh_t` mode (#844)
- IRMQTTServer: Generate protocol and bit size html selects (#838)

**[Misc]**
- New example code to show how to use the `IRac` class to control A/Cs (#839)
- Improve/fix `swingh_t::kWide` support (#846)
- Kelvinator: Optimise code a little to save space. (#843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amcor ADR-853H AC Support
1 participant
@crankyoldgit