Add various options #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that errors on nightly are ignored, because nightly is unpredictable. Fixes #37
|
cc @djc |
This was referenced Jul 21, 2019
|
Awesome! |
epage
reviewed
Jul 22, 2019
epage
reviewed
Jul 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
=====================================
Hits 5 5
Continue to review full report at Codecov.
|
|
Pushed one more option that enables you to skip |
jonhoo
added a commit
to tokio-rs/tracing
that referenced
this pull request
Jul 22, 2019
We need support for _not_ running with `--all-features` due to the nightly requirement for async/await which is enabled by a feature in `tracing`. This will eventually land with crate-ci/azure-pipelines#42.
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Jul 22, 2019
* First draft of Azure Pipelines CI config You'll have to follow the instructions over at https://github.com/crate-ci/azure-pipelines to get it fully set up. Might also run into some weirdness with having to change the "default" branch once merged. But 🎉 Oh, yeah, and need to also update Cargo.toml, README badge, etc. * Also check benchmarks * Pool is set per job, not per stage * Not a template anymore * Use correct service connection name * Disable readme doctest pending rewrite * Fully remove old doctest readme * Don't run cargo check yet We need support for _not_ running with `--all-features` due to the nightly requirement for async/await which is enabled by a feature in `tracing`. This will eventually land with crate-ci/azure-pipelines#42. * Hack dependency chain Closes #177
epage
approved these changes
Jul 22, 2019
hawkw
pushed a commit
to tokio-rs/tracing
that referenced
this pull request
Jul 22, 2019
Brings back `cargo check` as discussed here: #191 (comment) now that crate-ci/azure-pipelines#42 has landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a few requested features (#37 and #41), as well as for running tests single-threaded (
--test-threads=1), which some projects need.