Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage is broken #336

Closed
djc opened this issue Apr 28, 2019 · 6 comments
Closed

Code coverage is broken #336

djc opened this issue Apr 28, 2019 · 6 comments

Comments

@djc
Copy link
Collaborator

djc commented Apr 28, 2019

Apparently broken because of rust-lang/rust#58375, and we failed to notice for a long time because of xd009642/tarpaulin#219 (despite changes in #286 so far).

@Ralith
Copy link
Collaborator

Ralith commented Jul 22, 2019

Has this been fixed by the move to azure pipelines?

@djc
Copy link
Collaborator Author

djc commented Jul 22, 2019

The rustc has finally been fixed in Nightly this week, this is now pending crate-ci/azure-pipelines#42 so we can run the coverage on nightly until the fix gets to stable.

djc added a commit that referenced this issue Jul 22, 2019
- Run ignored tests, used for slow tests (we used to have this on Travis)
- Run coverage on nightly for now due to (see #336)
djc added a commit that referenced this issue Jul 22, 2019
- Run ignored tests, used for slow tests (we used to have this on Travis)
- Run coverage on nightly for now due to (see #336)
@djc
Copy link
Collaborator Author

djc commented Jul 22, 2019

Still not quite working, need to get xd009642/tarpaulin#239.

@djc
Copy link
Collaborator Author

djc commented Jul 23, 2019

In the ongoing saga, that issue has now been fixed but we appear to be running into (a variant of) xd009642/tarpaulin#190 now.

@stammw
Copy link
Contributor

stammw commented Mar 6, 2020

This issue can now be closed I guess ?

@djc
Copy link
Collaborator Author

djc commented Mar 6, 2020

Yes, at least this particular cause is no longer relevant.

@djc djc closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants