Fix uniqueness constraint with .auth.db.models.SqlUser.username
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
mlflow-2.8
branch
2 times, most recently
from
5f78a75
to
9da5b07
Compare
amotl
commented
Nov 1, 2023
mlflow_cratedb/patch/mlflow/model.py
Outdated
Comment on lines
13
to
23
| TODO: There are two more unique constraints defined on the MLflow data model. | ||
| - SqlExperimentPermission: "experiment_id", "user_id" | ||
| - SqlRegisteredModelPermission: "name", "user_id" | ||
| """ | ||
| from mlflow.store.model_registry.dbmodels.models import SqlRegisteredModel | ||
| from mlflow.store.tracking.dbmodels.models import SqlExperiment | ||
| from mlflow.server.auth.db.models import SqlUser | ||
|
|
||
| listen(SqlExperiment, "before_insert", check_uniqueness_factory(SqlExperiment, "name")) | ||
| listen(SqlRegisteredModel, "before_insert", check_uniqueness_factory(SqlRegisteredModel, "name")) | ||
| listen(SqlUser, "before_insert", check_uniqueness_factory(SqlUser, "username")) |
There was a problem hiding this comment.
Other than the constraint on SqlUser added on behalf of this patch, there are two more to be addressed. Both can be found within *Permission types of classes. I don't know if you are using this subsystem of MLflow, @andnig?
There was a problem hiding this comment.
The emulative implementation currently is not able to handle composite unique key constraints, so I've created a corresponding issue to track it. Even more yak shaving ahead.
amotl
force-pushed
the
amo/fix-uniquness-SqlUser
branch
from
8b4fb77
to
bc06315
Compare
amotl
force-pushed
the
amo/fix-uniquness-SqlUser
branch
from
bc06315
to
1e39d65
Compare
seut
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Just a minor followup to GH-46.
Trivia
The first CI run on this patch experienced an interesting fluke with CrateDB. We added a report at GH-53.