Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version drop-down menu no longer works #281

Closed
nomicode opened this issue May 27, 2021 · 8 comments · Fixed by #283
Closed

The version drop-down menu no longer works #281

nomicode opened this issue May 27, 2021 · 8 comments · Fixed by #283
Labels
bug Something isn't working

Comments

@nomicode
Copy link
Contributor

nomicode commented May 27, 2021

Steps to reproduce:

  1. visit any page, e.g., https://crate.io/docs/crate/reference/en/4.5/index.html
  2. click the version drop-down menu (at time of writing, the menu selection defaults to "v:4.5")

What happens:

  • nothing

What I expect to happen:

  • the drop-down menu shows me a list of available versions that I can select from

Tested using:

  • Chrome on macOS (with hard refresh and incognito mode)
  • Safar on macOS (ditto)

More:

I see lots of errors (or things that look like issues) in the dev console. I expect this relates to #277. however, clicking the drop-down does not produce any new errors in addition to the messages that already appear

@nomicode nomicode added the bug Something isn't working label May 27, 2021
@nomicode
Copy link
Contributor Author

cc @msbt @amotl

@msbt
Copy link
Collaborator

msbt commented May 27, 2021

@norosa this could be related to the position of jquery in the order of loading things, I'll talk @amotl to see what we can do about it

@amotl
Copy link
Member

amotl commented May 27, 2021

@norosa: Thank you for reporting this.
@msbt: Is it possible that we lost this feature when dropping the bootstrap.js file the other day?

@msbt
Copy link
Collaborator

msbt commented May 27, 2021

@amotl close, it seems to be related to the webflow.js we were using, seems to be a bit over the top, having a 140k library for a hover effect ;) when I have time I could rebuild the thing, but can we readd it for now so it works again?

@amotl
Copy link
Member

amotl commented May 27, 2021

Here we go. Do you believe #282 will be sufficient or do we also need to re-add https://github.com/webflow/js-webflow-api?

@amotl
Copy link
Member

amotl commented May 27, 2021

Thanks for your suggestion at #282 (comment), maybe #283 will get things straight now?

@amotl
Copy link
Member

amotl commented May 27, 2021

Hi again,

the problem has been fixed. I verified it on those pages:

With kind regards,
Andreas.

@nomicode
Copy link
Contributor Author

thanks so much folks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants