Delayed cronjob re-enabling after cluster upgrade/resume #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaharanne
force-pushed
the
p/cluster-update-timeout
branch
2 times, most recently
from
116a7b6
to
be39cd1
Compare
plaharanne
force-pushed
the
p/delay-cronjob
branch
2 times, most recently
from
9581fa4
to
18fa540
Compare
plaharanne
requested review from
tomach,
WalBeh,
Taliik,
juanpardo and
SStorm
as code owners
plaharanne
changed the title
juanpardo
reviewed
Feb 9, 2024
plaharanne
force-pushed
the
p/delay-cronjob
branch
8 times, most recently
from
45ca945
to
f63f530
Compare
SStorm
reviewed
Feb 15, 2024
| @@ -344,3 +347,36 @@ async def resume_sql_exporter_configmap( | |||
| """ | |||
| await raise_on_namespace_terminating(namespace) | |||
| await update_sql_exporter_configmap(namespace, name, logger) | |||
|
|
|||
|
|
|||
| @kopf.timer( | |||
plaharanne
force-pushed
the
p/delay-cronjob
branch
5 times, most recently
from
26037cb
to
bd1496b
Compare
use timer to unsuspend the cronjob
plaharanne
force-pushed
the
p/delay-cronjob
branch
from
bd1496b
to
e7fd71e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The
AfterClusterUpdateSubHandleris now split in two. The first one is as it used to be and the second one is to re-enable the cronjob.This new handler is not added to the
depends_onlist because it can be delayed by 1h in some cases. It means that the success notification will be sent and the handler will be executed later (if an issue occur, theerrordecorator will do the trick).The delay is applied if
delay_cronjob=Trueis in the status. It is set to True in theupgradehandler.Checklist
CHANGES.rst