Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a hard limit for max TCP connections #603

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Set a hard limit for max TCP connections #603

merged 1 commit into from
Mar 19, 2024

Conversation

SStorm
Copy link
Contributor

@SStorm SStorm commented Feb 29, 2024 •
edited by tomach

Summary of changes

  • Share k8s api client and set a hard limit for max TCP connections
  • Remove the sql-exporter configmap check on resume
  • Remove requests to retrieve the sts and ns in the health pings

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/1718
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@SStorm SStorm force-pushed the r/poc-tcp-connector-limit branch 3 times, most recently from 6d43fd3 to a465329 Compare March 6, 2024 16:21
@tomach tomach force-pushed the r/poc-tcp-connector-limit branch 3 times, most recently from ab663cf to 048ee77 Compare March 14, 2024 13:06
@tomach tomach marked this pull request as ready for review March 18, 2024 13:18
@tomach tomach merged commit 0c7478e into master Mar 19, 2024
5 checks passed
@tomach tomach deleted the r/poc-tcp-connector-limit branch March 19, 2024 09:15
@tomach tomach mentioned this pull request Mar 19, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taliik Taliik Taliik approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne plaharanne is a code owner

@tomach tomach Awaiting requested review from tomach tomach is a code owner

@WalBeh WalBeh Awaiting requested review from WalBeh WalBeh is a code owner

@juanpardo juanpardo Awaiting requested review from juanpardo juanpardo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SStorm @Taliik @tomach