Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix gc tests #604

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Try to fix gc tests #604

merged 1 commit into from
Mar 11, 2024

Conversation

tomach
Copy link
Contributor

@tomach tomach commented Mar 5, 2024 •
edited

Summary of changes

This fixes the failing tests when starting a cluster with gc enabled is blocked and hence timing out.

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/1724
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach marked this pull request as ready for review March 8, 2024 14:36
SStorm
SStorm approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@SStorm SStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tomach tomach merged commit 15ed913 into master Mar 11, 2024
5 checks passed
@tomach tomach deleted the ta/fix-gc-tests branch March 11, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SStorm SStorm SStorm approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne plaharanne is a code owner

@WalBeh WalBeh Awaiting requested review from WalBeh WalBeh is a code owner

@Taliik Taliik Awaiting requested review from Taliik Taliik is a code owner

@juanpardo juanpardo Awaiting requested review from juanpardo juanpardo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomach @SStorm