Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery Tests Backport #162

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Recovery Tests Backport #162

merged 1 commit into from
Nov 2, 2020

Conversation

mkleen
Copy link
Contributor

@mkleen mkleen commented Oct 16, 2020 •
edited
Loading

Summary of the changes / Why this is an improvement

Backport of https://github.com/elastic/elasticsearch/blob/master/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/RecoveryIT.java

On jenkins the tests needs much more waiting time than running the tests locally. Also using assertBusy would be a good idea instead of using time.sleep.

The following tests are excluded from this pr:

Checklist

  • CLA is signed

@mkleen mkleen self-assigned this Oct 19, 2020
@mkleen mkleen changed the title Backport of a test for recovery with concurrent indexing Backport of recovery tests from es Oct 22, 2020
@mkleen mkleen force-pushed the mkleen/recover_test branch 4 times, most recently from c4d608d to d2ed44d Compare October 28, 2020 15:51
@mkleen mkleen changed the title Backport of recovery tests from es Recovery Tests Oct 29, 2020
@mkleen mkleen changed the title Recovery Tests Recovery Tests Backport Oct 29, 2020
@mkleen mkleen marked this pull request as ready for review October 29, 2020 15:27
@mkleen mkleen force-pushed the mkleen/recover_test branch 3 times, most recently from 8044546 to 32ef08e Compare October 29, 2020 16:12
@mkleen mkleen force-pushed the mkleen/recover_test branch 6 times, most recently from ca7a1ba to 632331f Compare October 30, 2020 07:50
mfussenegger
mfussenegger reviewed Oct 30, 2020
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
tests/bwc/test_recovery.py Outdated Show resolved Hide resolved
tests/bwc/test_recovery.py Outdated Show resolved Hide resolved
tests/bwc/test_recovery.py Outdated Show resolved Hide resolved
@mkleen mkleen force-pushed the mkleen/recover_test branch 5 times, most recently from 24dc5e7 to b76fa78 Compare October 30, 2020 15:35
@mkleen mkleen force-pushed the mkleen/recover_test branch 3 times, most recently from a26dec6 to fc004b6 Compare November 1, 2020 18:27
@mkleen
Copy link
Contributor Author

mkleen commented Nov 1, 2020

retest this please

@mkleen
Copy link
Contributor Author

mkleen commented Nov 2, 2020

This is ready for another review.

@mkleen mkleen force-pushed the mkleen/recover_test branch 3 times, most recently from e6487b7 to fcec41e Compare November 2, 2020 10:55
mfussenegger
mfussenegger approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@mfussenegger mfussenegger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mkleen
Copy link
Contributor Author

mkleen commented Nov 2, 2020

retest this please

@mkleen
Add recovery tests
2558dcc 
In depth testing of the recovery mechanism during a rolling restart.
Based on org.elasticsearch.upgrades.RecoveryIT.java
@mkleen mkleen merged commit 2d71263 into master Nov 2, 2020
@mkleen mkleen deleted the mkleen/recover_test branch November 2, 2020 13:42
@mkleen mkleen mentioned this pull request Nov 10, 2020
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfussenegger mfussenegger mfussenegger approved these changes

Assignees

@mkleen mkleen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkleen @mfussenegger