fixup! fixup! reduce overhead in hostname and id node expressions

crate · Apr 30, 2015 · 567a73a · 567a73a
1 parent 594c338
commit 567a73a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/sql/src/main/java/io/crate/operation/reference/sys/node/NodeHostnameExpression.java b/sql/src/main/java/io/crate/operation/reference/sys/node/NodeHostnameExpression.java
@@ -23,6 +23,7 @@
 
 import org.apache.lucene.util.BytesRef;
 import org.elasticsearch.cluster.ClusterService;
+import org.elasticsearch.cluster.node.DiscoveryNode;
 import org.elasticsearch.common.inject.Inject;
 
 public class NodeHostnameExpression extends SysNodeExpression<BytesRef> {
@@ -38,8 +39,9 @@ public NodeHostnameExpression(ClusterService clusterService) {
 
     @Override
     public BytesRef value() {
-        if (clusterService.localNode() != null) {
-            return new BytesRef(clusterService.localNode().getHostName());
+        DiscoveryNode localNode = clusterService.localNode();
+        if (localNode != null) {
+            return new BytesRef(localNode.getHostName());
         }
         return null;
     }

diff --git a/sql/src/main/java/io/crate/operation/reference/sys/node/NodeIdExpression.java b/sql/src/main/java/io/crate/operation/reference/sys/node/NodeIdExpression.java
@@ -23,6 +23,7 @@
 
 import org.apache.lucene.util.BytesRef;
 import org.elasticsearch.cluster.ClusterService;
+import org.elasticsearch.cluster.node.DiscoveryNode;
 import org.elasticsearch.common.inject.Inject;
 import org.elasticsearch.discovery.Discovery;
 
@@ -41,9 +42,10 @@ public NodeIdExpression(ClusterService clusterService) {
 
     @Override
     public BytesRef value() {
+        DiscoveryNode localNode = clusterService.localNode();
         // value could not be ready on node start-up, but is static once set
-        if (value == null && clusterService.localNode() != null) {
-            value = new BytesRef(clusterService.localNode().getId());
+        if (value == null && localNode != null) {
+            value = new BytesRef(localNode.getId());
         }
         return value;
     }