Skip to content

Commit

Permalink
remove lastEmittedDocPerShard logic from QueryThenFetchTask
Browse files Browse the repository at this point in the history
was always null / unused
  • Loading branch information
mfussenegger committed Nov 17, 2014
1 parent b626f3d commit 988811a
Showing 1 changed file with 3 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,12 @@ private void moveToSecondPhase() throws IOException {
return;
}

final ScoreDoc[] lastEmittedDocPerShard = null;
// searchPhaseController.getLastEmittedDocPerShard(request, sortedShardList, firstResults.length());

final AtomicInteger counter = new AtomicInteger(docIdsToLoad.asList().size());
for (AtomicArray.Entry<IntArrayList> entry : docIdsToLoad.asList()) {
QuerySearchResult queryResult = firstResults.get(entry.index);
DiscoveryNode node = nodes.get(queryResult.shardTarget().nodeId());
FetchSearchRequest fetchSearchRequest = createFetchRequest(queryResult, entry, lastEmittedDocPerShard);

FetchSearchRequest fetchSearchRequest = new FetchSearchRequest(EMPTY_SEARCH_REQUEST, queryResult.id(), entry.value);
executeFetch(entry.index, queryResult.shardTarget(), counter, fetchSearchRequest, node);
}
}
Expand Down Expand Up @@ -366,16 +364,7 @@ private void releaseIrrelevantSearchContexts(AtomicArray<QuerySearchResult> firs
}
}

protected FetchSearchRequest createFetchRequest(QuerySearchResult queryResult,
AtomicArray.Entry<IntArrayList> entry,
ScoreDoc[] lastEmittedDocPerShard) {
if (lastEmittedDocPerShard != null) {
ScoreDoc lastEmittedDoc = lastEmittedDocPerShard[entry.index];
return new FetchSearchRequest(EMPTY_SEARCH_REQUEST, queryResult.id(), entry.value, lastEmittedDoc);
} else {
return new FetchSearchRequest(EMPTY_SEARCH_REQUEST, queryResult.id(), entry.value);
}
}

@Override
public List<ListenableFuture<QueryResult>> result() {
return results;
Expand Down

0 comments on commit 988811a

Please sign in to comment.