Add ids to logical plans #13525
Closed
Add ids to logical plans #13525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleen
force-pushed
the
mkleen/logical-plan-ids
branch
3 times, most recently
from
58aa365
to
0cd5cda
Compare
mkleen
commented
Jan 26, 2023
| @@ -43,11 +44,12 @@ public SubqueryPlanner(Function<SelectSymbol, LogicalPlan> planSubSelects) { | |||
|
|
|||
| public record SubQueries(Map<LogicalPlan, SelectSymbol> uncorrelated, Map<SelectSymbol, LogicalPlan> correlated) { | |||
|
|
|||
| public LogicalPlan applyCorrelatedJoin(LogicalPlan source) { | |||
| public LogicalPlan applyCorrelatedJoin(LogicalPlan source, IntSupplier ids) { | |||
There was a problem hiding this comment.
I am trying to use IntSupplier () -> Int instead of the PlannerContext if possible, as it's simply much less hassle to build and to handle e.g. in tests.
mkleen
commented
Jan 26, 2023
| LogicalPlan apply(T plan, | ||
| Captures captures, | ||
| TableStats tableStats, | ||
| TransactionContext txnCtx, |
There was a problem hiding this comment.
We could introduce a RuleContext including TransactionContext, NodeContext and PlannerContext and TableStats.
mkleen
force-pushed
the
mkleen/logical-plan-ids
branch
from
0cd5cda
to
69f28b6
Compare
This assigns to each logical plan node an id as part of the planning phase. This makes logical plans identifiable. This is useful for keeping track of changes on the logical operator node tree. Main concepts: - Each newly created logical plan gets a new id - Id's of logical plans have to be unique within one planning phase - When a logical plan is modified e.g. by a rule transformation it will get a new id - An incrementing int on the planner context is used to generate the ids This is a pre-requisite for the iterative optimizer #13340
mkleen
force-pushed
the
mkleen/logical-plan-ids
branch
from
69f28b6
to
689ee45
Compare
|
Converting back to draft. I would like to do one more iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assigns to each logical plan node an id as part of the planning phase. This makes logical plans identifiable. This is useful for keeping track of changes on the logical operator node tree.
Main concepts:
This is a pre-requisite for the iterative optimizer #13340
Summary of the changes / Why this improves CrateDB
Checklist
CHANGES.txtfor user facing changessql_featurestable for user facing changesCHANGES.txt(E.g. AdminUI)