Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented collector context #1709

Merged
merged 1 commit into from
Feb 23, 2015
Merged

implemented collector context #1709

merged 1 commit into from
Feb 23, 2015

Conversation

mfelsche
Copy link
Contributor

for storing the shard collectors search context that can be retrieved later on

CollectNode collectNode = new CollectNode("bla", docTableInfo.getRouting(WhereClause.MATCH_ALL, null));
collectNode.jobId(UUID.randomUUID());
collectNode.maxRowGranularity(RowGranularity.DOC);
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is try/catch here really needed/wanted?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho exceptions should bubble

@seut
Copy link
Member

seut commented Feb 23, 2015

otherwise ack if travis failures are unrelated

for storing the shard collectors search context that can be retrieved later on
mfelsche added a commit that referenced this pull request Feb 23, 2015
implemented collector context
@mfelsche mfelsche merged commit 4f3ccb7 into cross_joins Feb 23, 2015
@mfelsche mfelsche deleted the m/collect_ctx branch February 23, 2015 20:57
mfelsche pushed a commit that referenced this pull request Feb 24, 2015
This reverts commit 4f3ccb7, reversing
changes made to 7deb93a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants