Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table settings altering #2004

Merged
merged 1 commit into from
May 12, 2015
Merged

Conversation

pustovit
Copy link
Contributor

No description provided.

@@ -22,6 +22,7 @@
package io.crate.analyze;

import com.google.common.base.Joiner;
import com.sun.tools.classfile.Opcode;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import not used

@mfelsche
Copy link
Contributor

test create table as well

@mfelsche
Copy link
Contributor

check correct validation for the new settings with the correct settingsapplier

@mfelsche
Copy link
Contributor

test ALTER TABLE reset as well

}
};

public static final StringSetting ROUTING_ALLOCATION_ENABLE = new StringSetting(Sets.newHashSet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ImmutableSet.of(...)

@mfelsche
Copy link
Contributor

ack

pustovit added a commit that referenced this pull request May 12, 2015
@pustovit pustovit merged commit 7333e50 into table-settings-feature May 12, 2015
@pustovit pustovit deleted the e/table-settings-altering branch May 12, 2015 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants