add CrossJoinConsumer #2231
Merged
add CrossJoinConsumer #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
3fa1c82
to
0b8fc9d
Compare
mfussenegger
force-pushed
the
cross-joins
branch
2 times, most recently
from
baad44f
to
0c739da
Compare
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
0b8fc9d
to
d1ea52f
Compare
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
d1ea52f
to
9036eb6
Compare
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
9036eb6
to
0079146
Compare
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
39aa084
to
8eb8548
Compare
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
3 times, most recently
from
4bc7aee
to
92ac701
Compare
| localExecutionNodes | ||
| ); | ||
| nl = new NestedLoop(jobId, lastNL, right, nestedLoopPhase, true, null); | ||
| */ |
|
add a planner test like discussed |
|
please rebase master into cross-joins and then cross-joins into this branch. There are some changes (e.g. TransportExecutor ) which should be already in master |
This was already rebased against master but I removed the branch logic in the TransportExecutor when I cherry-picked it because it was unused due to the missing NL plan. |
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
92ac701
to
089efbf
Compare
mfussenegger
force-pushed
the
cross-joins
branch
3 times, most recently
from
d0fcb5a
to
40050a2
Compare
(cherry-picked from old cross-join branch)
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
2 times, most recently
from
1c438bc
to
40bcb00
Compare
| QueryAndFetch leftPlan = (QueryAndFetch) plan.left().plan(); | ||
| CollectPhase collectPhase = leftPlan.collectNode(); | ||
| assertThat(collectPhase.projections().size(), is(1)); | ||
| TopNProjection topN = ((TopNProjection) collectPhase.projections().get(0)); |
There was a problem hiding this comment.
please change the comment in https://github.com/crate/crate/pull/2231/files#diff-7159fb3ea2b2d07a81f969fbc77c1f7dR210 it's confusing
| @javax.annotation.Nullable | ||
| @Override | ||
| public PageDownstreamContext pageDownstreamContext(byte inputId) { | ||
| assert inputId == 0 : "This downstream context only support 1 input"; |
|
ack |
mfussenegger
force-pushed
the
j/cross-join-consumer
branch
from
7ff6057
to
3d58a81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.