run response actionListener in SAME ThreadPool #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ack |
mfussenegger
force-pushed
the
j/response-handler
branch
from
c64418c
to
85004b9
Compare
|
otherwise ack |
mfussenegger
force-pushed
the
j/response-handler
branch
from
85004b9
to
e884570
Compare
usually the onResponse operation is very cheap and can run on the IO/caller thread directly. If the response operation is expensive the listener should be wrapped into a ThreadedActionListener or a different ResponseHandler should be used. This avoids EsRejectedExecutionExceptions which can cause queries to get stuck as the response could be swallowed.
mfussenegger
force-pushed
the
j/response-handler
branch
from
e884570
to
6d07121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usually the onResponse operation is very cheap and can run on the IO/caller
thread directly.
If the response operation is expensive the listener should be wrapped into a
ThreadedActionListener or a different ResponseHandler should be used.
This avoids EsRejectedExecutionExceptions which can cause queries to get stuck
as the response could be swallowed.