use pause / resume in DistributingDownstream #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfussenegger
force-pushed
the
j/pause-resume-dd
branch
from
557a6f5
to
f7f5c6c
Compare
| transportDistributedResultAction.pushResult( | ||
| node, | ||
| new DistributedResultRequest(jobId, targetExecutionPhaseId, inputId, bucketIdx, streamers, throwable), | ||
| NO_OP_ACTION_LISTENER |
There was a problem hiding this comment.
inline this, and at least log response failures
|
ack |
This eliminates the Queue from the DistributingDownstream. Instead the StreamBuckets are used directly to save the rows. In addition the Broadcasting/Modulo distribution has been decoupled from the request handling.
mfussenegger
force-pushed
the
j/pause-resume-dd
branch
from
22044a7
to
b808ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the Queue from the DistributingDownstream. Instead the
StreamBuckets are used directly to save the rows.
In addition the Broadcasting/Modulo distribution has been decoupled from the
request handling.