change TopNProjectors to Pipes #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private Object[] spare; | ||
|
|
||
| /** | ||
| * @param inputs contains output {@link io.crate.operation.Input}s and orderBy {@link io.crate.operation.Input}s | ||
| * @param collectExpressions gathered from outputs and orderBy inputs | ||
| * @param numOutputs <code>inputs</code> contains this much output {@link io.crate.operation.Input}s starting form index 0 | ||
| * @param orderBy indices of {@link io.crate.operation.Input}s in parameter <code>inputs</code> we sort by | ||
| * @param reverseFlags for every index orderBy a boolean indicates ascending (<code>false</code>) or descending (<code>true</code>) order | ||
| * @param ordering ordering that is used to compare the materialized rows |
There was a problem hiding this comment.
why do you state materialized here explicitly?
mfussenegger
force-pushed
the
j/more-pipes
branch
from
ada00c1
to
5f9e62e
Compare
mfussenegger
force-pushed
the
j/more-pipes
branch
from
5f9e62e
to
4dcf55d
Compare
|
ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.