use table stats to decide which side of NL to broadcast #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertThat(statsService.numDocs(new TableIdent("foo", "bar")), is(2L)); // first call triggers request | ||
| assertThat(statsService.numDocs(new TableIdent("foo", "bar")), is(2L)); // second call hits cache | ||
| int slept = 0; | ||
| while (numRequests.get() < 2 && slept < 1000) { |
There was a problem hiding this comment.
should be, the slept < 1000 is just a failsafe in case numRequests never increases (which should after 100 ms are elapsed)
|
otherwise ack |
The smaller table should be broadcasted. This can significantly speed up query execution if the size difference of the tables is very big. In a simple test it reduced the time for a query from 125 sec to 0.8 sec
mfussenegger
force-pushed
the
j/table-stats
branch
from
44766be
to
32f4fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smaller table should be broadcasted. This can significantly speed up query
execution if the size difference of the tables is very big.
In a simple test it reduced the time for a query from 125 sec to 0.8 sec