remove schemaInfo property from TableInfo #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,7 +204,7 @@ public void testBuildCreateTablePrimaryKey() throws Exception { | |||
| new ColumnIdent("pk_col_two") | |||
| ); | |||
|
|
|||
| DocTableInfo tableInfo = new TestDocTableInfo(MY_SCHEMA_INFO, | |||
There was a problem hiding this comment.
is it possible to delete MY_SCHEMA_INFO?
|
otherwise ack |
In most cases schemaInfo was only used to check if it is a systemSchema which was redundant because in all cases there was already a DocTableInfo instance available which indicates that it can't be a systemSchema. This also makes testing a bit easiser as the schemaInfo doesn't have to be mocked (and in some cases we forgot to mock it's name which lead to strange tests where the schemaName was just empty)
mfussenegger
force-pushed
the
j/no-schema-info
branch
from
f44028d
to
4ccc79f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases schemaInfo was only used to check if it is a systemSchema
which was redundant because in all cases there was already a
DocTableInfo instance available which indicates that it can't be a
systemSchema.
This also makes testing a bit easiser as the schemaInfo doesn't have to
be mocked (and in some cases we forgot to mock it's name which lead to
strange tests where the schemaName was just empty)